q8webmaster commented on PR #8230:
URL: https://github.com/apache/paimon/pull/8230#issuecomment-6739173694

   Thanks a lot @JingsongLi for the thorough review here, and sorry I wasn't 
able to follow up on your comments. Your points about existing 
`TIMESTAMP_MILLIS` files (footer stats decoding and predicate pushdown) were 
exactly the gaps in this approach.
   
   Thanks also @0dunay0 for picking this up and carrying it through in #10601, 
and for the narrower, opt-in design. It solves the same Iceberg v2 
compatibility problem more cleanly: `MICROS` is written only when 
`metadata.iceberg.storage` is enabled, MILLIS and MICROS files can coexist in 
one table, and `ParquetFilters` converts literals per file unit. That covers 
everything this PR set out to fix, so I'm closing this one in favour of the 
merged fix.
   
   Thanks again, both of you!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to