JingsongLi commented on code in PR #1348:
URL: https://github.com/apache/paimon-rust/pull/1348#discussion_r4521792835


##########
crates/integrations/datafusion/src/procedures.rs:
##########
@@ -206,16 +206,17 @@ async fn earlier_or_equal_from_all(
     }
 }
 
-/// The parameter names each `sys.*` procedure declares, in Java's order. Java 
rejects a
-/// CALL argument that no parameter declares, so a typo cannot be dropped in 
silence: a
-/// misspelled `snapshot_id` on `create_tag` would otherwise tag the latest 
snapshot, and
-/// a misspelled `index_type` on `create_global_index` would build the default 
index.
+/// The parameter names each `sys.*` procedure declares, in Java's order, 
followed by
+/// any Rust extensions. Java rejects a CALL argument that no parameter 
declares, so a
+/// typo cannot be dropped in silence: a misspelled `snapshot_id` on 
`create_tag` would
+/// otherwise tag the latest snapshot, and a misspelled `index_type` on
+/// `create_global_index` would build the default index.
 fn declared_parameters(proc_name: &str) -> Option<&'static [&'static str]> {
     Some(match proc_name {
         "create_branch" => &["table", "branch", "tag", "ignore_if_exists"],
         "create_tag" => &["table", "tag", "snapshot_id", "time_retained"],
         "replace_tag" => &["table", "tag", "snapshot_id", "time_retained"],
-        "delete_tag" => &["table", "tag"],
+        "delete_tag" => &["table", "tag", "exact"],

Review Comment:
   Please keep `sys.delete_tag(table, tag)` aligned with Java. Flink and Spark 
both expose those two arguments and use comma-separated tag names. Remove the 
`exact` parameter and its tests and documentation from this PR, and keep the 
change focused on routing tag operations through the REST catalog. [Java Flink 
procedure](https://paimon.apache.org/docs/master/flink/procedures/tags-and-branches/#delete_tag)
 ยท [Java Spark 
procedure](https://github.com/apache/paimon/blob/5982b1241aef46d8da03205373e4600c16e213b0/paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/procedure/DeleteTagProcedure.java#L34-L38)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to