JingsongLi commented on PR #1348:
URL: https://github.com/apache/paimon-rust/pull/1348#issuecomment-6785350936

   Requirement fit: SUPPORTED. The previous tag authority, numeric-version 
fallback, retained-file accounting, legacy dot-tag and `delete_tag(table, tag)` 
findings are addressed. I found no new implementation defect in the reviewed 
paths. Local REST core tests, real `paimon-rest-server` end-to-end tests, SQL 
procedures/REST management/time-travel tests, strict docs build and formatting 
checks passed.
   
   **Production rollout needs an explicit server-first and tag-migration 
condition.** The client now probes the REST tag endpoint before resolving 
numeric `scan.version` / `VERSION AS OF`, and only HTTP 501 enables the 
snapshot/watermark fallback. Against an older server returning an untyped 404 
for that route, a readable snapshot 1 fails with `Table sales.orders does not 
exist`. I reproduced this over HTTP with two real filesystem snapshots: 
explicit `scan.snapshot-id=1` succeeds under 404, `scan.version=1` fails, and 
changing the tag response to 501 restores `scan.version=1`.
   
   Please add an upgrade note requiring the endpoint implementation (or 
explicit 501 behavior) before deploying the new client. Also call out 
reconciliation of tags previously written only to table storage by the old REST 
procedures: those tags intentionally disappear from the new 
catalog-authoritative reads, so existing tag-based workloads need an 
audit/migration before the switch. Automatic fallback to storage would 
reintroduce the wrong-snapshot bug and is not the requested fix.
   
   For `$referenced_files_size`, the deployment must additionally support 
catalog branch listing and current/tag snapshot retrieval; the in-tree server 
still lacks branch listing, so that query is intentionally unsupported there. I 
have not verified a live production REST backend. Release verdict: PASS WITH 
CONDITIONS on these capability and migration checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to