0dunay0 commented on code in PR #10995:
URL: https://github.com/apache/paimon/pull/10995#discussion_r4528858866


##########
paimon-core/src/main/java/org/apache/paimon/iceberg/IcebergCommitCallback.java:
##########
@@ -484,6 +567,7 @@ private void createMetadataWithoutBase(
             int lastColumnIdFloor,
             long nextRowIdFloor)
             throws IOException {
+        replayPoint(ReplayPoint.REBUILD, snapshotId);
         SnapshotReader snapshotReader = 
table.newSnapshotReader().withSnapshot(snapshotId);

Review Comment:
   The rebuild now takes the Snapshot that was checked, not its id, on every 
path, including the fallback after a failed replay. The overloads that reloaded 
the snapshot by number are gone. The rebuild checks the snapshot on disk 
against that identity before it plans and reads its splits from that very 
snapshot. It checks again under the lock before the publication, as every 
publisher does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to