Akash3121 commented on code in PR #11070:
URL: https://github.com/apache/paimon/pull/11070#discussion_r4531216728
##########
paimon-python/pypaimon/tests/lerobot_aggregate_test.py:
##########
@@ -248,6 +252,58 @@ def test_merge_numbering_stats_and_training(setup,
import_parallelism):
assert selected[0]["episode_index"].item() == 2
+def test_merge_keeps_source_specific_episode_statistics_in_json(setup):
+ conn, sources = setup
+ for index, uri in enumerate(sources):
+ path = Path(uri[7:]) / "meta/episodes/chunk-000/file-000.parquet"
Review Comment:
Could we convert this file URI with a platform-aware helper instead of
slicing it? On Windows, `Path.as_uri()` returns `file:///C:/...`, so `uri[7:]`
produces `/C:/...` and this new test fails before exercising the merge logic
with `WinError 123`. For example, `Path(url2pathname(urlparse(uri).path))`
works on both Windows and POSIX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]