lucasfang opened a new issue, #548:
URL: https://github.com/apache/paimon-cpp/issues/548

   ### Problem
   
   `BlobFallbackBatchReaderTest.TestRejectsBatchExceedingReadLimit` 
intermittently fails on `release-0.4` at commit 
`b6c035026acdb4ec8c5a252854963a541417b61e` (v0.4.0-rc4).
   
   Observed in the [gcc-release-aarch64 CI 
job](https://github.com/apache/paimon-cpp/actions/runs/42935354612/job/130243961626):
   
   ```
   'reader->NextBatch()' did not fail
   ```
   
   ### Cause and expected behavior
   
   The test needs its oversized mock reader to return two rows for a one-row 
read/skip request. However, `MockFileBatchReader` randomizes the batch size by 
default in the range [1, 1024]. When it chooses 1, the returned batch satisfies 
the limit, so the expected error correctly does not occur. Both the covered and 
uncovered cases can hit this.
   
   Disable batch-size randomization for this mock so both paths always exercise 
rejection of an oversized batch. Production reader behavior and the existing 
assertions should stay unchanged.
   
   ### Reproduction
   
   Repeat the test on the affected revision:
   
   ```sh
   ./build/debug/paimon-common-test \
     
--gtest_filter=BlobFallbackBatchReaderTest.TestRejectsBatchExceedingReadLimit \
     --gtest_repeat=3000
   ```
   
   The previous local investigation reproduced 6 failures in 3000 iterations on 
x86_64 Debug; this is not specific to aarch64.
   
   ### Release backport
   
   The exact one-line fix is already on main in #534, commit 
`7515bf6837af93e12e8ce610779146533966b747`. This issue tracks backporting only 
that test fix to `release-0.4`, without the query-auth feature or other changes 
from #534.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to