lucasfang opened a new pull request, #549:
URL: https://github.com/apache/paimon-cpp/pull/549

   ### Purpose
   
   Linked issue: closes #548
   
   Backport the one-line flaky-test fix from #534 
(`7515bf6837af93e12e8ce610779146533966b747`) to `release-0.4`.
   
   `TestRejectsBatchExceedingReadLimit` needs the mock to return two rows for a 
one-row read/skip request. The mock randomizes batch sizes by default, 
occasionally returning only one row and making the expected rejection 
disappear. Disable randomization for this oversized mock so both the covered 
and uncovered paths always exercise the existing assertion.
   
   Scope: one line in one test file. No production changes or other changes 
from #534.
   
   ### Tests
   
   The existing 
`BlobFallbackBatchReaderTest.TestRejectsBatchExceedingReadLimit` still covers 
both read and skip requests and verifies that the request context is cleared 
after rejection.
   
   Local validation on x86_64 Debug with ASAN:
   - Recompiled the release-branch test source using the existing configured 
build's flags and libraries; the relevant reader implementation, header and 
mock were verified identical.
   - `BlobFallbackBatchReaderTest.*`: 17 tests passed.
   - `BlobFallbackBatchReaderTest.TestRejectsBatchExceedingReadLimit 
--gtest_repeat=3000`: all 3000 iterations passed.
   - `pre-commit run --files 
src/paimon/common/reader/blob_fallback_batch_reader_test.cpp` and `git diff 
--check`: passed.
   
   The original test previously failed 6 times in 3000 local iterations. The 
failing aarch64 Release CI job and a fresh full release-branch build were not 
rerun locally.
   
   ### API and Format
   
   No public API, storage format or protocol changes.
   
   ### Documentation
   
   No documentation changes are needed for this test-only fix.
   
   ### Generative AI tooling
   
   Generated-by: OpenAI Codex (GPT-6)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to