lucasfang commented on code in PR #547:
URL: https://github.com/apache/paimon-cpp/pull/547#discussion_r4535625183
##########
src/paimon/core/mergetree/in_memory_sort_buffer.cpp:
##########
@@ -135,6 +135,7 @@ Result<int64_t> InMemorySortBuffer::EstimateMemoryUse(const
std::shared_ptr<arro
case arrow::Type::type::INT32:
return null_bits_size_in_bytes + array->length() * sizeof(int32_t);
case arrow::Type::type::DATE32:
+ case arrow::Type::type::TIME32:
Review Comment:
Nit (non-blocking): Could we group `INT32`, `DATE32`, and `TIME32` under the
same return statement here? All three use the same `sizeof(int32_t)` memory
estimate, so sharing the branch would remove the duplicate expression without
changing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]