yunfengzhou-hub commented on code in PR #11015:
URL: https://github.com/apache/paimon/pull/11015#discussion_r4537977644


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/FlinkSinkBuilder.java:
##########
@@ -351,6 +353,61 @@ protected DataStreamSink<?> buildDynamicBucketSink(
 
     protected DataStreamSink<?> buildForFixedBucket(DataStream<InternalRow> 
input) {
         int bucketNums = table.bucketSpec().getNumBuckets();
+        Options options = Options.fromMap(table.options());
+        // sink.striped-bucket-write.enabled is the sole switch; 
writers-per-bucket only applies
+        // when it is

Review Comment:
   Fixed. Striped write now rejects any configured primary-key index (vector, 
full-text, FM, BTree, bitmap, multivalue), since all are maintained per bucket 
by a single publisher. The check uses CoreOptions.primaryKeyIndexEnabled(), 
shared with KeyValueFileStore#newFixedBucketWrite so the guard and the 
maintainer creation cannot drift apart. This closes the FIRST_ROW + 
vector/full-text gap you reproduced.
   
   testStripedWriteRejectsPrimaryKeyIndex covers the rejection, using a 
full-text index on a FIRST_ROW table with deletion vectors disabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to