yunfengzhou-hub commented on code in PR #11015:
URL: https://github.com/apache/paimon/pull/11015#discussion_r4501139325


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/FlinkSinkBuilder.java:
##########
@@ -351,6 +353,54 @@ protected DataStreamSink<?> buildDynamicBucketSink(
 
     protected DataStreamSink<?> buildForFixedBucket(DataStream<InternalRow> 
input) {
         int bucketNums = table.bucketSpec().getNumBuckets();
+        Options options = Options.fromMap(table.options());
+        // sink.striped-bucket-write.enabled is the sole switch; 
writers-per-bucket only applies
+        // when it is
+        // on
+        if 
(options.get(FlinkConnectorOptions.SINK_STRIPED_BUCKET_WRITE_ENABLED)) {

Review Comment:
   Added a guard in FlinkSinkBuilder.buildForFixedBucket: striped write of an 
append-only table now requires bucket-append-ordered=false and is rejected at 
sink build time otherwise; primary-key tables are unaffected. 
testStripedWriteRejectsOrderedAppend covers the rejection, and the append 
end-to-end test now sets bucket-append-ordered=false. The requirement is 
documented in the striped-write warning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to