mvanhorn commented on code in PR #11102:
URL: https://github.com/apache/paimon/pull/11102#discussion_r4552826629


##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -324,6 +329,15 @@ public List<ManifestCommittable> 
filterCommitted(List<ManifestCommittable> commi
                     result.add(committable);
                 } else {
                     commitCallbacks.forEach(callback -> 
callback.retry(committable));
+                    Snapshot snapshot = latestSnapshot.get();
+                    if (committable.identifier() == snapshot.commitIdentifier()
+                            && (snapshot.commitKind() == CommitKind.APPEND

Review Comment:
   Good catch, thanks. 49ef4c4 adds a check in recoverCompact: before replaying 
a recovered COMPACT, compactInputsStillLive verifies that every compactBefore 
file is still an ADD entry in the latest snapshot, and filterCommitted drops 
the recovery when one was removed by a concurrent compaction. 
FileStoreCommitTest gets 
testFilterHalfCommittedIdentifierWithConcurrentlyCompactedInput for that case.
   
   <!-- r:da5b6594a246.bbc5896fdb93 -->



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to