mvanhorn commented on code in PR #11102:
URL: https://github.com/apache/paimon/pull/11102#discussion_r4582243583


##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -549,7 +762,7 @@ private int overwritePartition(
         }
 
         try {
-            boolean skipOverwrite = false;
+            boolean skipOverwrite = committable instanceof 
CompactRecoveryCommittable;

Review Comment:
   Fixed in 96ad422: overwritePartition now commits its compact phase through 
the same tryCommitCompact helper as commit(), so it sets the recovery flag and 
drops a stale recovery instead of throwing. 
testRecoverHalfCommittedIdentifierWithConcurrentOverlap is the deterministic 
OVERWRITE overlap regression you asked for, with an APPEND control.
   
   <!-- r:387280646efc.d4a39232ed6f -->



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to