dragonknightk commented on PR #1394:
URL: https://github.com/apache/paimon-rust/pull/1394#issuecomment-6910469698

   Thanks @JingsongLi for the detailed probes, both are addressed now.
   
   1. `sink.parallelism = -1` now keeps one writer, the same as an absent 
option, matching how FlinkSinkBuilder treats -1. Zero, other negative values 
and non-integers are still rejected. A table-driven test covers -1 on an append 
table, a fixed-bucket table, a primary-key table and INSERT OVERWRITE.
   2. The parallel sink now polls the input and all writer tasks together, so 
the first writer failure ends the statement and cancels the remaining work, 
also while the input is pending. Two `write_all` tests on a local filesystem 
table cover your case (a writer fails, the input stays pending) and the 
creation-order join case (a later writer fails while an earlier one is still 
waiting for input).
   
   The PR description is updated accordingly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to