Smith-Cruise commented on code in PR #1394:
URL: https://github.com/apache/paimon-rust/pull/1394#discussion_r4596701810
##########
crates/integrations/datafusion/src/physical_plan/sink.rs:
##########
@@ -116,6 +128,106 @@ impl PaimonDataSink {
overwrite,
}
}
+
+ /// Number of `TableWrite`s for this statement, capped by the session's
+ /// `target_partitions`. The option is validated for every table. Any
+ /// writer may write any partition only for bucket-unaware append-only
+ /// tables, so other tables and overwrites keep the single writer.
+ fn writer_count(&self, target_partitions: usize) -> DFResult<usize> {
+ let options = self.table.schema().options();
+ let parallelism = match options.get(SINK_PARALLELISM) {
+ None => return Ok(1),
Review Comment:
I have a question: why do we need to follow `sink.parallelism` parameter?
It's flink's config. I think we follow datafusion's `target_partitions` is
enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]