dragonknightk commented on PR #11181:
URL: https://github.com/apache/paimon/pull/11181#issuecomment-7004574699

   @JingsongLi Thanks for this one. I had only made sure the end-input 
maintenance finishes before `close()`, and missed what happens when it fails 
after the snapshot is already published.
   
   A retry now finishes that maintenance. When every committable is filtered 
out as committed and the last one is the end-input commit, the retry commits no 
data again, but runs the same awaited maintenance on the executor. If the 
maintenance fails again, the retry fails too, so it never reports success while 
the tag is still missing.
   
   I added three tests based on your repro: the retry creates the missing tag, 
the retry fails while the tag write keeps failing, and the retry of an already 
committed checkpoint commit does not run maintenance. The PR description is 
updated to match. PTAL (๑•̀ㅂ•́)و✧
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to