dragonknightk commented on PR #11181:
URL: https://github.com/apache/paimon/pull/11181#issuecomment-7041501195

   @JingsongLi No, this was not found in a real production env. AI found it in 
the code when I was checking #5681 and #6593, and it was reproduced on Flink 
1.20.5 + Paimon 2.1.0 (with `snapshot.expire.execution-mode = async`, snapshots 
keep growing past the retention limit across batch runs).
   
   After your reminder, I thought more carefully about whether this change is 
really needed, and saw in the docs that the default is `sync`. Also, after the 
review changes, this PR touches the concurrency and retry paths in 
`TableCommitImpl`.
   
   I think I should close this PR and keep #11180 and this thread for 
reference. We can come back to it later if users report that it affects 
production. Thanks for taking a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to