ZENOTME commented on code in PR #1465:
URL: https://github.com/apache/paimon-rust/pull/1465#discussion_r4640078465
##########
crates/paimon/src/table/data_file_writer.rs:
##########
@@ -317,7 +317,6 @@ impl DataFileWriter {
.new_file_name(&self.data_file_prefix, &self.file_format);
let location = self.paths.new_path(&file_name)?;
let bucket_dir = location.parent();
- self.file_io.mkdirs(&format!("{bucket_dir}/")).await?;
Review Comment:
My understanding is that each operator handles parent directories as needed.
E.g. [FsWriter::create() calls
ensure_write_abs_path()](https://docs.rs/opendal-service-fs/0.59.5/src/opendal_service_fs/writer.rs.html#45),
which creates missing parent directories. [The WebDAV writer does the same by
default in
WebdavWriter::write_once().](https://docs.rs/opendal-service-webdav/0.59.5/src/opendal_service_webdav/writer.rs.html#65)
Is there a use case for disabling automatic directory creation when the
WebDAV server requires the parent to exist, or is the concern mainly backward
compatibility with providers that rely on Paimon to create it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]