QuakeWang commented on code in PR #1465:
URL: https://github.com/apache/paimon-rust/pull/1465#discussion_r4640191747


##########
crates/paimon/src/table/data_file_writer.rs:
##########
@@ -317,7 +317,6 @@ impl DataFileWriter {
             .new_file_name(&self.data_file_prefix, &self.file_format);
         let location = self.paths.new_path(&file_name)?;
         let bucket_dir = location.parent();
-        self.file_io.mkdirs(&format!("{bucket_dir}/")).await?;

Review Comment:
   Mainly backward compatibility. I don’t have a concrete use case for that 
WebDAV setup. I used it to reproduce what happens when a custom provider relies 
on Paimon to create the bucket directory.
   
   I’m fine with leaving parent directory creation to the operator and 
documenting that in FileIOProvider. @JingsongLi  does that match what you’d 
expect from FileIOProvider?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to