lxy-9602 commented on code in PR #584:
URL: https://github.com/apache/paimon-cpp/pull/584#discussion_r4656756312


##########
include/paimon/read_context.h:
##########
@@ -208,6 +209,8 @@ class PAIMON_EXPORT ReadContext {
     void SetReadSchema(std::unique_ptr<ArrowSchema> schema);
 
  private:
+    friend class FileStoreTable;

Review Comment:
   Hi, @realAaronWu Thanks for working on this. Before reviewing the 
implementation in detail, could you share some measurements or a representative 
estimate of the memory retained by the schema JSON—for example, typical schema 
sizes, the number of concurrent read contexts, and the resulting share of 
overall memory usage?
   
   I’m a little hesitant to make `FileStoreTable` a friend of `ReadContext` 
solely to release this string. Understanding the expected savings would help us 
assess whether the additional coupling is justified, or whether a more 
encapsulated approach would be preferable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to