lxy-9602 commented on code in PR #584:
URL: https://github.com/apache/paimon-cpp/pull/584#discussion_r4657027845
##########
include/paimon/read_context.h:
##########
@@ -208,6 +209,8 @@ class PAIMON_EXPORT ReadContext {
void SetReadSchema(std::unique_ptr<ArrowSchema> schema);
private:
+ friend class FileStoreTable;
Review Comment:
Thank you for the detailed measurements and thoughtful response. I agree
that we can defer this optimization for now.
We’re also working on the broader Table-layer refactoring tracked in #459,
and #555 specifically covering the separation of table-loading inputs from
operation contexts. The direction is to create read/write/scan/commit
operations from a loaded Table and reuse its schema and other shared resources,
rather than carry that information separately in each operation context.
With this separation, read contexts would no longer need to retain the
schema JSON, which should also address the concern raised in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]