ravwojdyla commented on code in PR #1240:
URL: https://github.com/apache/parquet-mr/pull/1240#discussion_r1430082393
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/MemoryManager.java:
##########
@@ -74,7 +75,7 @@ private void checkRatio(float ratio) {
* @param writer the new created writer
* @param allocation the requested buffer size
*/
- synchronized void addWriter(InternalParquetRecordWriter<?> writer, Long
allocation) {
+ void addWriter(InternalParquetRecordWriter<?> writer, Long allocation) {
Review Comment:
Thanks for the input @wgtmac! It's unfortunate that an expected behavior is
not tested, maybe this PR will be a good place alleviate that. But first I
would like to ask if we all agree there's an issue here as described in
[here](https://github.com/apache/parquet-mr/pull/1240#discussion_r1424446622),
and as I believe evident from the lock statistics in the the [comment
above](https://github.com/apache/parquet-mr/pull/1240#issuecomment-1850726993)?
And if we agree, do you have any recommendations how to move forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
