wgtmac commented on code in PR #1240:
URL: https://github.com/apache/parquet-mr/pull/1240#discussion_r1430341003
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/MemoryManager.java:
##########
@@ -74,7 +75,7 @@ private void checkRatio(float ratio) {
* @param writer the new created writer
* @param allocation the requested buffer size
*/
- synchronized void addWriter(InternalParquetRecordWriter<?> writer, Long
allocation) {
+ void addWriter(InternalParquetRecordWriter<?> writer, Long allocation) {
Review Comment:
Unfortunately I do not have too much experience in using this code path. The
MemoryManager was introduced long ago to address memory issue for dynamic
partition. I'm not sure if Apache Spark or other engines are using it or not.
May I seek advise from @dongjoon-hyun @sunchao @parthchandra @shangxinli to see
if you have seen this problem before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
