amousavigourabi commented on code in PR #1242:
URL: https://github.com/apache/parquet-mr/pull/1242#discussion_r1436117400
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetRecordReader.java:
##########
@@ -155,8 +155,15 @@ private void initializeInternalReader(ParquetInputSplit
split, Configuration con
}
// open a reader with the metadata filter
- ParquetFileReader reader =
- ParquetFileReader.open(HadoopInputFile.fromPath(path, configuration),
optionsBuilder.build());
+ HadoopInputFile inputFile;
+ if (split.getFooter() != null
+ && split.getFooter().getInputFile() != null
+ && split.getFooter().getInputFile() instanceof HadoopInputFile) {
Review Comment:
Hi @wgtmac, given that the `inputFile` variable seems to only be used in a
constructor expecting an `InputFile` and not necessarily a `HadoopInputFile`, I
think this `instanceof` condition could be dropped. As I just quickly skimmed
it now and might have missed something, I'll take a more thorough look after
Boxing Day. Happy holidays!🎄🎆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
