amousavigourabi commented on code in PR #1242:
URL: https://github.com/apache/parquet-mr/pull/1242#discussion_r1437073638
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetRecordReader.java:
##########
@@ -155,8 +155,15 @@ private void initializeInternalReader(ParquetInputSplit
split, Configuration con
}
// open a reader with the metadata filter
- ParquetFileReader reader =
- ParquetFileReader.open(HadoopInputFile.fromPath(path, configuration),
optionsBuilder.build());
+ HadoopInputFile inputFile;
+ if (split.getFooter() != null
+ && split.getFooter().getInputFile() != null
+ && split.getFooter().getInputFile() instanceof HadoopInputFile) {
Review Comment:
Looking good! Going back to @wgtmac's earlier concern, the method this
snippet is part of is already in the Hadoop code path and I'm not sure whether
there is a more generic alternative available. For the rest, the switch to
using the plain `InputFile` interface here is of course amazing for flexibility
in the future and makes the code a bit cleaner. Thanks a lot for the swift fix
@wankunde!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
