gszadovszky commented on code in PR #1274: URL: https://github.com/apache/parquet-mr/pull/1274#discussion_r1494133508
########## parquet-common/src/main/java/org/apache/parquet/bytes/TrackingByteBufferAllocator.java: ########## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.parquet.bytes; + +import java.nio.ByteBuffer; +import java.util.HashMap; +import java.util.Map; + +/** + * A wrapper {@link ByteBufferAllocator} implementation that tracks whether all allocated buffers are released. It + * throws the related exception at {@link #close()} if any buffer remains un-released. It also clears the buffers at + * release so if they continued being used it'll generate errors. + * <p>To be used for testing purposes. Review Comment: How would we differentiate test and prod envs? I would not like to put warns in the test env either. One would need to explicitly define a `ByteBufferAllocator` instance to use it in prod. I would expect reading the specs before using a class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
