gszadovszky commented on code in PR #1274:
URL: https://github.com/apache/parquet-mr/pull/1274#discussion_r1494135917
##########
parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java:
##########
@@ -43,15 +42,15 @@ class MultiBufferInputStream extends ByteBufferInputStream {
private List<ByteBuffer> markBuffers = new ArrayList<>();
MultiBufferInputStream(List<ByteBuffer> buffers) {
- this.buffers = buffers;
+ List<ByteBuffer> buffersCopy = new ArrayList<>(buffers);
Review Comment:
TBH, this is not needed. It was kind of automatic to copy the list instead
of using the one got from outside. But the whole point of these classes is
performance. So I'll revert this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
