gszadovszky commented on code in PR #1292:
URL: https://github.com/apache/parquet-mr/pull/1292#discussion_r1514722436
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java:
##########
@@ -168,12 +168,7 @@ public DataPage visit(DataPageV1 dataPageV1) {
decompressedBuffer,
dataPageV1.getUncompressedSize());
setDecompressMetrics(bytes, start);
-
- // HACKY: sometimes we need to do `flip` because the position of
output bytebuffer is
Review Comment:
Since we already defined the contract which actually requires a flip to be
invoked here, I don't think we need the comment, especially not calling this
hacky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
