gszadovszky commented on code in PR #1292:
URL: https://github.com/apache/parquet-mr/pull/1292#discussion_r1514728613
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/DirectCodecFactory.java:
##########
@@ -68,7 +68,8 @@ class DirectCodecFactory extends CodecFactory implements
AutoCloseable {
try {
tempClass =
Class.forName("org.apache.hadoop.io.compress.DirectDecompressionCodec");
tempCreateMethod = tempClass.getMethod("createDirectDecompressor");
- tempDecompressMethod = tempClass.getMethod("decompress",
ByteBuffer.class, ByteBuffer.class);
+ Class<?> tempClass2 =
Class.forName("org.apache.hadoop.io.compress.DirectDecompressor");
+ tempDecompressMethod = tempClass2.getMethod("decompress",
ByteBuffer.class, ByteBuffer.class);
Review Comment:
Yes. Because of that the class `FullDirectDecompressor` was never used but
fell back to `IndirectDecompressor`. That's why we never have an actual failure
because the functionality was covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
