clairemcginty opened a new pull request, #1293: URL: https://github.com/apache/parquet-mr/pull/1293
This is a very basic **draft/proof of concept** of [PARQUET-2443](https://issues.apache.org/jira/browse/PARQUET-2443). It modifies ParquetFileReader to construct a lazily-evaluating _iterator_ of Data Pages rather than a materialized `List`. Materialization is controlled via a new Configuration option. Looking for feedback on the idea/general approach to solving this. This touches a lot of parquet-core which I wasn't familiar with before this PR, so I'm not sure this is the best approach. ### Jira - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR" - https://issues.apache.org/jira/browse/PARQUET-2443 - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Tests Some basic unit tests have been added, but more intense testing is needed (and a memory profile to make sure the evaluation is actually happening lazily). I decided to put this up as a draft PR to get some feedback on the proof of concept first, though. - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Style - [x] My contribution adheres to the code style guidelines and Spotless passes. - To apply the necessary changes, run `mvn spotless:apply -Pvector-plugins` ### Documentation - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain Javadoc that explain what it does -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
