clairemcginty commented on code in PR #1293:
URL: https://github.com/apache/parquet-mr/pull/1293#discussion_r1518972215
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -1274,7 +1276,7 @@ private void readChunkPages(Chunk chunk, BlockMetaData
block, ColumnChunkPageRea
} else { // encrypted column
rowGroup.addColumn(
chunk.descriptor.col,
- chunk.readAllPages(
+ chunk.readAllPages( // @Todo this must be made lazy too?
Review Comment:
Update: I pushed a very messy first attempt at making the file
SeekableByteStream allocation lazy, as well. Will clean it up over the week,
but any initial feedback is very welcome :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
