wgtmac commented on code in PR #1273:
URL: https://github.com/apache/parquet-mr/pull/1273#discussion_r1524275724
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java:
##########
@@ -39,11 +36,20 @@
/**
* A set of options to create a ParquetRewriter.
+ *
+ * TODO find a place where to put a proper description of functionality as it
is not trivial:
+ * ParquetRewriter allows to stitch files with the same schema into a single
file.
+ * Note that ParquetRewriter also can be used for effectively stitch/joining
multiple parquet files with
+ * different schemas.
+ * You can provide the main input file group and multiple right side ones.
That is possible when:
+ * 1) the number of rows in the main and extra input groups are the same,
+ * 2) the ordering of rows in the main and extra input groups is the same.
*/
public class RewriteOptions {
private final ParquetConfiguration conf;
private final List<InputFile> inputFiles;
+ private final List<List<InputFile>> inputFilesR;
Review Comment:
That make sense. Files on the right side do not need to make number of rows
to the left side.
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java:
##########
@@ -39,11 +36,20 @@
/**
* A set of options to create a ParquetRewriter.
+ *
+ * TODO find a place where to put a proper description of functionality as it
is not trivial:
+ * ParquetRewriter allows to stitch files with the same schema into a single
file.
+ * Note that ParquetRewriter also can be used for effectively stitch/joining
multiple parquet files with
+ * different schemas.
+ * You can provide the main input file group and multiple right side ones.
That is possible when:
+ * 1) the number of rows in the main and extra input groups are the same,
+ * 2) the ordering of rows in the main and extra input groups is the same.
*/
public class RewriteOptions {
private final ParquetConfiguration conf;
private final List<InputFile> inputFiles;
+ private final List<List<InputFile>> inputFilesR;
Review Comment:
That make sense. Files on the right side do not need to match number of rows
to the left side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
