ahshahid commented on PR #1309: URL: https://github.com/apache/parquet-mr/pull/1309#issuecomment-2033082014
@wgtmac @gszadovszky Thanks for reviewing and your inputs. I agree , for buffered streams ,flush is necessary before closing.. Yes, my thinking too is that if flush throws an Exception, close in any case would throw.. But if you believe not 100% guaranteed, can modify the code to attempt close irrespective of flush's outcome. I have not seen AutoCloseable... let me check.. if it is little invasive, I will avoid using as I am not well versed with the parquet codebase.. After the PR is merged, may be more knowledgeable can refine it. I will check for OutputStream.close.. Though I assume when you say outside of parquet-mr, you mean other places in parquet-mr project only right..? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
