ahshahid commented on code in PR #1309:
URL: https://github.com/apache/parquet-mr/pull/1309#discussion_r1548823537
##########
parquet-column/src/main/java/org/apache/parquet/column/values/bitpacking/BitPackingValuesWriter.java:
##########
@@ -108,7 +109,11 @@ public void reset() {
@Override
public void close() {
- out.close();
+ try (CapacityByteArrayOutputStream cbaos = out) {
+ cbaos.flush();
Review Comment:
You want me to remove that ?. For safe side, I am calling flush.. wherever
there is buffering possibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
