wgtmac commented on PR #1139:
URL: https://github.com/apache/parquet-mr/pull/1139#issuecomment-2038653314

   > @steveloughran This looks really great! I think my only comment would be 
about wether we can expose the implementation in a way that might be more 
pluggable. In Iceberg we have a similar parallel to the InputFile and 
SeekableStream, but it's not apparent to me that we would be able to adapt our 
IO implementation to leverage vectored reads.
   > 
   > Open to thoughts on how we might do that as well.
   > 
   > Maybe this would be possible by implementing the vectoredIO methods in the 
[Iceberg adaptor class 
here](https://github.com/apache/iceberg/blob/c07f2aabc0a1d02f068ecf1514d2479c0fbdd3b0/parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java#L105)?
   
   Do you want to double check this again? @danielcweeks @Fokko 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to