wgtmac commented on code in PR #1139:
URL: https://github.com/apache/parquet-mr/pull/1139#discussion_r1559607836


##########
parquet-common/src/main/java/org/apache/parquet/io/SeekableInputStream.java:
##########
@@ -104,4 +106,25 @@ public abstract class SeekableInputStream extends 
InputStream {
    *                      fill the buffer, {@code buf.remaining()}
    */
   public abstract void readFully(ByteBuffer buf) throws IOException;
+
+  /**
+   * Read a set of file ranges in a vectored manner.
+   *
+   * @param ranges the list of file ranges to read
+   * @param allocator the allocator to use for allocating ByteBuffers
+   * @throws UnsupportedOperationException if not available in this 
class/runtime (default)
+   */
+  public void readVectored(List<ParquetFileRange> ranges, final 
ByteBufferAllocator allocator) throws IOException {
+
+    throw new UnsupportedOperationException("Vectored IO is not supported for 
" + this);
+  }
+
+  /**
+   * Is the {@link #readVectored(List, ByteBufferAllocator)} method available?
+   * @param allocator the allocator to use for allocating ByteBuffers

Review Comment:
   What's your opinion in this? @steveloughran 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to