rok commented on code in PR #241: URL: https://github.com/apache/parquet-format/pull/241#discussion_r1602290688
########## LogicalTypes.md: ########## @@ -255,6 +255,18 @@ The primitive type is a 2-byte fixed length binary. The sort order for `FLOAT16` is signed (with special handling of NANs and signed zeros); it uses the same [logic](https://github.com/apache/parquet-format#sort-order) as `FLOAT` and `DOUBLE`. +### FIXED_SIZE_LIST + +The `FIXED_SIZE_LIST` annotation represents a fixed-size list of elements +of a fixed-width data type. It must annotate an N-byte fixed length binary Review Comment: My assumption was `fixed_len_byte_array` will give us better performance than `binary` but we then require constant bit width. Are you saying we could relax this condition, use `binary` and cover non-fixed-width types? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
