etseidl commented on code in PR #241: URL: https://github.com/apache/parquet-format/pull/241#discussion_r1602302147
########## LogicalTypes.md: ########## @@ -255,6 +255,16 @@ The primitive type is a 2-byte fixed length binary. The sort order for `FLOAT16` is signed (with special handling of NANs and signed zeros); it uses the same [logic](https://github.com/apache/parquet-format#sort-order) as `FLOAT` and `DOUBLE`. +### FIXED_SIZE_LIST + +The `FIXED_SIZE_LIST` annotation represents a fixed-size list of elements +of a primitive data type. It must annotate a `binary` primitive type. + +The `fixed_len_byte_array` data is interpreted as a sequence of elements of +the same primitive data type. Review Comment: If this is only for primitive types, should the type be added to the `FixedSizedListType` struct? ########## LogicalTypes.md: ########## @@ -255,6 +255,16 @@ The primitive type is a 2-byte fixed length binary. The sort order for `FLOAT16` is signed (with special handling of NANs and signed zeros); it uses the same [logic](https://github.com/apache/parquet-format#sort-order) as `FLOAT` and `DOUBLE`. +### FIXED_SIZE_LIST + +The `FIXED_SIZE_LIST` annotation represents a fixed-size list of elements +of a primitive data type. It must annotate a `binary` primitive type. + +The `fixed_len_byte_array` data is interpreted as a sequence of elements of Review Comment: ```suggestion The `binary` data is interpreted as a sequence of elements of ``` ########## LogicalTypes.md: ########## @@ -255,6 +255,16 @@ The primitive type is a 2-byte fixed length binary. The sort order for `FLOAT16` is signed (with special handling of NANs and signed zeros); it uses the same [logic](https://github.com/apache/parquet-format#sort-order) as `FLOAT` and `DOUBLE`. +### FIXED_SIZE_LIST + +The `FIXED_SIZE_LIST` annotation represents a fixed-size list of elements +of a primitive data type. It must annotate a `binary` primitive type. Review Comment: "binary" means either fixed or variable length, right? I always get confused 😅. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
