clairemcginty commented on PR #1328: URL: https://github.com/apache/parquet-mr/pull/1328#issuecomment-2117481105
> This overall LGTM! Thanks @clairemcginty for working on this and adding exhaustive test! great, I'm glad this implementation looks ok! I have a few more tests that I'd like to add around null handling + behavior of the `Contains` predicate on map types (I think that they should just work, but I haven't tried it out yet...). Will try to add those + address PR comments on Monday or Tuesday next week 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
