clairemcginty commented on code in PR #1328:
URL: https://github.com/apache/parquet-mr/pull/1328#discussion_r1606767983
##########
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/ColumnIndexBuilder.java:
##########
@@ -368,6 +369,20 @@ public <T extends Comparable<T>> PrimitiveIterator.OfInt
visit(NotIn<T> notIn) {
return IndexIterator.all(getPageCount());
}
+ @Override
+ public <T extends Comparable<T>> PrimitiveIterator.OfInt visit(Contains<T>
contains) {
Review Comment:
Makes sense. I'll look into doing an intersection/union operation here. Or
otherwise just fall back to not filtering and returning `IndexIterator.all`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
