alamb commented on code in PR #244:
URL: https://github.com/apache/parquet-format/pull/244#discussion_r1606007758
##########
src/main/thrift/parquet.thrift:
##########
@@ -625,7 +631,11 @@ struct DataPageHeaderV2 {
/** Number of NULL values, in this data page.
Number of non-null = num_values - num_nulls which is also the number of
values in the data section **/
2: required i32 num_nulls
- /** Number of rows in this data page. which means pages change on record
boundaries (r = 0) **/
Review Comment:
I also propose expanding the `r = 0` terminology to be explicitly
`repetition_level = 0` to match the conventions in the rest of the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
