alamb commented on code in PR #244:
URL: https://github.com/apache/parquet-format/pull/244#discussion_r1608043291
##########
src/main/thrift/parquet.thrift:
##########
@@ -578,7 +578,13 @@ enum BoundaryOrder {
/** Data page header */
struct DataPageHeader {
- /** Number of values, including NULLs, in this data page. **/
+ /**
+ * Number of values, including NULLs, in this data page.
+ *
+ * If a ColumnIndex is present, a page must begin at a record
Review Comment:
I also asked for clarification on the mailing list:
https://lists.apache.org/thread/rd8twnvg4bg3558r507rzpxckcxt5wdn
Upon further thought it seems like since `OffsetIndex` is a pointer from
records to pages, then maybe this is more accurate:
```suggestion
* If a OffsetIndex is present, a page must begin at a record
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
