wgtmac commented on code in PR #245:
URL: https://github.com/apache/parquet-format/pull/245#discussion_r1606156924
##########
src/main/thrift/parquet.thrift:
##########
@@ -738,10 +738,10 @@ struct PageHeader {
}
/**
- * Wrapper struct to specify sort order
+ * Sort order within a RowGroup
*/
struct SortingColumn {
- /** The column index (in this row group) **/
+ /** The ordinal position of the column (in this row group) **/
Review Comment:
I'd suggest to explicitly say it is a leaf column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
