alamb commented on code in PR #245: URL: https://github.com/apache/parquet-format/pull/245#discussion_r1606762494
########## PageIndex.md: ########## @@ -19,9 +19,11 @@ # ColumnIndex Layout to Support Page Skipping -This document describes the format for column index pages in the Parquet -footer. These pages contain statistics for DataPages and can be used to skip -pages when scanning data in ordered and unordered columns. +In Parquet, a "Page Index" is optional metadata for a Review Comment: After some thought, I think using "page index" (non capitalized) might be best because while `ColumnIndex` and `OffsetIndex` are names of thrift structs, `PageIndex` is not. So referring to `PageIndex` as though it were a struct I think will cause more confusion I tried to clarify this in 0afdcd9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
