etseidl commented on code in PR #242:
URL: https://github.com/apache/parquet-format/pull/242#discussion_r1608610520
##########
src/main/thrift/parquet.thrift:
##########
@@ -885,6 +973,44 @@ struct ColumnChunk {
9: optional binary encrypted_column_metadata
}
+struct ColumnChunkV3 {
+ /** File where column data is stored. **/
+ 1: optional string file_path
+
+ /** Byte offset in file_path to the ColumnChunkMetaDataV3, optionally
encrypted
+ ** CHANGED from v1: renamed to metadata_file_offset
+ **/
+ 2: required i64 metadata_file_offset
+
+ /** NEW from v1: Byte length in file_path of ColumnChunkMetaDataV3,
optionally encrypted
+ **/
+ 3: required i32 metadata_file_length
Review Comment:
Thank you :)
The naming is a little awkward...I read these as "metadata-file
offset"/"metadata-file length". Perhaps instead just "metadata_offset" and
"metadata_length"?
Aside: just curious, but in the current format how do you make use of the
`file_offset`? Is there a way to deduce the length of the metadata? Or do you
have to use a file based reader and seek to the offset?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
