emkornfield commented on code in PR #242:
URL: https://github.com/apache/parquet-format/pull/242#discussion_r1608904923
##########
src/main/thrift/parquet.thrift:
##########
@@ -467,6 +467,35 @@ struct SchemaElement {
10: optional LogicalType logicalType
}
+struct SchemaElementV3 {
+ /** Data type for this field. */
+ 1: optional Type type;
+
+ /** If type is FIXED_LEN_BYTE_ARRAY, this is the byte length of the values.
+ *
+ * CHANGED from v1: this must be omitted for other column types.
+ */
+ 2: optional i32 type_length;
+
+ /** repetition of the field. */
+ 3: optional FieldRepetitionType repetition_type;
+
+ /** Name of the field in the schema */
+ 4: required string name;
+
+ /** Nested fields. */
+ 5: optional i32 num_children;
+
+ /** CHANGED from v1: from i32 to i64
Review Comment:
I think it is backwards compatible and in the long run, it probably isn't a
big deal either way. I as just curious if there as a reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
