wgtmac commented on code in PR #1369:
URL: https://github.com/apache/parquet-java/pull/1369#discussion_r1626866212
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -534,8 +534,9 @@ private void addRowGroup(
int columnOrdinal = -1;
ByteArrayOutputStream tempOutStream = null;
for (ColumnChunkMetaData columnMetaData : columns) {
- ColumnChunk columnChunk =
- new ColumnChunk(columnMetaData.getFirstDataPageOffset()); // verify
this is the right offset
+ // There is no ColumnMetaData written after the chunk data, so set the
ColumnChunk
+ // file_offset to 0
+ ColumnChunk columnChunk = new ColumnChunk(0);
Review Comment:
parquet-cpp actually writes `ColumnMetaData` right after the last page of
the column and stores it into `file_offset` field:
https://github.com/apache/arrow/blob/6800be9331d88024bf550c77865a06c592a22699/cpp/src/parquet/metadata.cc#L1473-L1478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
