etseidl commented on PR #1369: URL: https://github.com/apache/parquet-java/pull/1369#issuecomment-2148840577
> I'd rather deprecate the field and document it should not be used rather than setting the value to zero. I agree with deprecating, but I'm less sanguine about leaving an incorrect value in parquet-java, especially given the fact that arrow-cpp (and arrow-rs I believe) populate this field correctly. Having such a big difference between major implementations is IMO more confusing than stating the field should be set to 0 (or -1) if there is no second copy of the `ColumnMetaData`. > it might break implementations that have been using this to find the first page. Implementations that do this will break anyway if they try to read a file produced by arrow, so I don't know how big of a concern this is. That said, if the consensus is to just leave this be, that's fine too...we'd just have to make note of differing interpretations in the format documents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
