clairemcginty opened a new pull request, #2941: URL: https://github.com/apache/parquet-java/pull/2941
This should be the final subtask for the Contains() predicate work. It adds support for logical inversion -- `not(contains(...))`. Also, it fixes a small bug with the composition of mixed Contains predicates. Make sure you have checked _all_ steps below. ### Issue - [x] My PR addresses the following [GitHub issues](https://github.com/apache/parquet-java/issues) and references them in the PR title. For example, "GH-1234: My Parquet PR" - https://issues.apache.org/jira/browse/PARQUET-34 (should I make a new Github issue for this?) - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [x] My commits all reference GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including GitHub issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Style - [ ] My contribution adheres to the code style guidelines and Spotless passes. - To apply the necessary changes, run `mvn spotless:apply -Pvector-plugins` ### Documentation - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain Javadoc that explain what it does -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
