clairemcginty commented on code in PR #2941:
URL: https://github.com/apache/parquet-java/pull/2941#discussion_r1665897688
##########
parquet-column/src/main/java/org/apache/parquet/filter2/recordlevel/IncrementallyUpdatedFilterPredicate.java:
##########
@@ -145,6 +146,83 @@ public boolean accept(Visitor visitor) {
}
}
+ /**
+ * A ValueInspector implementation that keeps state for one or more delegate
inspectors.
+ */
+ abstract static class DelegatingValueInspector extends ValueInspector {
Review Comment:
I created this because I thought the generated
`IncrementallyUpdatedFilterPredicateBuilder` was getting complex in terms of
LOC -- all the `Contains` ValueInspectors were overriding `public void
update(int|float|binary|double|... value)` as well as `reset()`, and it was
getting hard to reason about. However.... this is probably a bit less
efficient, since the delegate ValueInspectors are accessed via iterator loops
rather than directly invoking `left`/`right`. Let me know what you think, I'm
happy to change it back to the way it was
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
