MaxNevermind commented on code in PR #1335:
URL: https://github.com/apache/parquet-java/pull/1335#discussion_r1714628247
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java:
##########
@@ -358,6 +466,9 @@ public Builder indexCacheStrategy(IndexCache.CacheStrategy
cacheStrategy) {
public RewriteOptions build() {
Preconditions.checkArgument(inputFiles != null && !inputFiles.isEmpty(),
"Input file is required");
Preconditions.checkArgument(outputFile != null, "Output file is
required");
+ Preconditions.checkArgument(
+ inputFiles != null && !inputFiles.isEmpty(),
Review Comment:
Oh, yeah it was supposed to be for `inputFilesToJoin` not `inputFiles`. I
replaced that check with `(inputFilesToJoin != null ? inputFilesToJoin : new
ArrayList<>())` bellow. Hope this works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
